Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: markdown mistake when referring to an AIP #1317

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MasterMedo
Copy link

Currently, the AIP reference renders wrongly, and this commit fixes it.

image

@MasterMedo MasterMedo requested a review from a team as a code owner February 27, 2024 12:57
Copy link

google-cla bot commented Feb 27, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Contributor

@andrei-scripniciuc andrei-scripniciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for sending this out! the intent here was to link to the AIP, but it seems we missed including the link at the bottom of the page. Could you instead add a reference link to https://google.aip.dev/142? Something like:

[AIP-142]: https://google.aip.dev/142

https://www.markdownguide.org/basic-syntax/#reference-style-links

@MasterMedo
Copy link
Author

Sorry for the slow response.

the intent here was to link to the AIP, but it seems we missed including the link at the bottom of the page.

I don't think that needs to be added for the link to work. Look at other AIPs at https://google.aip.dev/162, they are automatically linked to the appropriate AIP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants